core docs: rewrite panic::Location::caller with visual line/column numbers
#148811
+57
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Some changes occurred in exhaustiveness checking cc @Nadrieril Some changes occurred in match lowering cc @Nadrieril Some changes occurred in src/tools/clippy cc @rust-lang/clippy Some changes occurred in match checking cc @Nadrieril Some changes occurred in src/tools/rustfmt cc @rust-lang/rustfmt |
Collaborator
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
rustbot
added
has-merge-commits
Paladynee
force-pushed
the
doc/location-caller-updated
branch
from
3684291 to
a721e7a
Compare
This comment has been minimized.
This comment has been minimized.
rustbot
removed
has-merge-commits
…mple without changing doctests
Paladynee
force-pushed
the
doc/location-caller-updated
branch
from
a721e7a to
ff7b6cc
Compare
theemathas
removed
T-rustdoc
Contributor
|
r? libs |
Author
|
@rustbot label +C-enhancement +A-docs |
Collaborator
|
Failed to set assignee to
|
rustbot
added
A-docs
Paladynee
changed the title
core::panic::Location::caller with visual line/column numberspanic::Location::caller with visual line/column numbers
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
rustbot
added
has-merge-commits
Author
|
oh god i hate git and github and |
Paladynee
force-pushed
the
doc/location-caller-updated
branch
from
4d0b4a3 to
ff7b6cc
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
rustbot
removed
S-waiting-on-author
rustbot
added
S-waiting-on-author
rustbot
added
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
no tracking issue
hey, this is my first PR on rust-lang/rust, so hopefully everything goes well.
i noticed the documentation for
core::panic::Location::callerwas kind of unintelligible (and maybe even wrong due to standalone_crate) and filled with magic numbers, so i provided line and column numbers as a visual guidance as to how it should be used.edit: uh oh, looks like i pushed changes from random commits unrelated to me, what's going on?
edit2: reverted the unintended changes by this pr